Author Topic: Lots of .txt fixes  (Read 264 times)

0 Members and 1 Guest are viewing this topic.

Offline barbeque

  • Crystal Pony
  • Silly Filly
  • Posts: 38
  • h
    • View Profile
Lots of .txt fixes
« on: June 15, 2019, 02:27:28 pm »
I noticed some songs actually crash USDX (any English Acadeca duet for example) and Ultrastar Play was also complaining about a bunch of other issues, mostly things like where the linebreak cuts through a note, but there were also some more creative ones like notes that were in the completely wrong order within a sentence.

So I made this big patch for the songs in the "Official" directory. Go to your 'Official' folder and apply the patch:
https://drive.google.com/file/d/1n-W04h6rPkIc31XkOrooxl_rE7t3xjQv/view?usp=sharing
(I did not want to paste it here because that might introduce encoding issues)

I'll be doing a similar thing for everything in the Community and Downloads folder in the coming weeks.

EDIT: there is one file that is not showing up in USDX at all:
Official/[HU][S1E14] A varras egy csoda/vidam.txt
I remove a duplicate #ENCODING tag from it with the patch, but it still does not want to show up. I have absolutely no idea what's wrong with it though.
« Last Edit: June 15, 2019, 02:30:33 pm by barbeque »
i am best barbeque. put your hamburgers on me.

Online Renard

  • Administrator
  • Silly Filly
  • Posts: 1 646
  • aka "MairusuPawa"
    • View Profile
Re: Lots of .txt fixes
« Reply #1 on: June 17, 2019, 09:17:18 pm »
Wow! That's a lot of fixes here. I'm going to try and review some of that before applying the patch, but still, thank you for that work. I do notice there's still encoding issues with at least French (eg: 1361 1 32 t�). Also, I've never experienced any crash with Acadeca so I'm a bit surprised about this one, but eh :)

Offline barbeque

  • Crystal Pony
  • Silly Filly
  • Posts: 38
  • h
    • View Profile
Re: Lots of .txt fixes
« Reply #2 on: June 18, 2019, 02:53:38 pm »
Ideally, you should review everything [that you apply]. Find some way to compare the situation before and after the patch more visually, like making a copy of the _entire_ 'Official' directory, apply the patch in only one of them, and then do a directory side-by-side comparison.

And this only fixes things within the .txt itself, in the ultrastardx logs I also noticed that there are a bunch that reference non-existing videos (which isn't too much of an issue, since it'll just use the background instead) but I like to keep the logs clean, so there will probably be a second patch for these at some point.

I didn't touch any encodings to my knowledge, but hence the need for a review/check. Remaining encoding issues are probably because the file itself isn't UTF-8 or something.
i am best barbeque. put your hamburgers on me.

Online Renard

  • Administrator
  • Silly Filly
  • Posts: 1 646
  • aka "MairusuPawa"
    • View Profile
Re: Lots of .txt fixes
« Reply #3 on: July 10, 2019, 09:56:10 am »
Late reply, but the reasoning behind the #VIDEO warnings is two-folds:
- In the early stages of development, we usually tried to use a header template. All karaoke engines are expected to fallback on the background image in case the video is missing (which is quite common with "light" packs distributed elsewhere, for which the original videos were simply deleted before redistribution) or if the video is present but can not be played (corrupted file, missing codecs or performance issues).
- It was supposed to makes things easier for us during updates. If a new video was created for an existing song, we could just drop the new file in place without having to overwrite the TXT.

Offline barbeque

  • Crystal Pony
  • Silly Filly
  • Posts: 38
  • h
    • View Profile
Re: Lots of .txt fixes
« Reply #4 on: October 14, 2019, 01:03:33 pm »
Haha, yeah, I thought that was the case with the #VIDEO things.

Also, two additional fixes for official songs (aka, songs that are in the 'Official' directory, things that came later via Downloads will be done separately, or perhaps as another reply on this topic):
  • There is an instrumtal.txt for This Is Our Big Night (EQG), but there is no instrumental.mp3
  • The regular S6E08 Hearth's Warming Eve Is Here Once Again references song_new.mp3 which does not exist. There is a song.mp3 though. Ie ingame, there is only the instrumental
i am best barbeque. put your hamburgers on me.